Skip to content

Bump corpus generator v0.6.0#1491

Closed
francescayeye wants to merge 23 commits intoelastic:mainfrom
francescayeye:bump-corpus-generator-v0.6.0
Closed

Bump corpus generator v0.6.0#1491
francescayeye wants to merge 23 commits intoelastic:mainfrom
francescayeye:bump-corpus-generator-v0.6.0

Conversation

@francescayeye
Copy link
Copy Markdown

@francescayeye francescayeye commented Oct 6, 2023

resolves manually conflicts at #1478
fixes #1474

@marc-gr do we use elsewhere the .size/.tot_events package specs?
I could not find any in integrations, but in case there are there, we should adapt a different strategy

@francescayeye francescayeye requested review from marc-gr and mrodm October 6, 2023 04:27
@francescayeye francescayeye self-assigned this Oct 6, 2023
@francescayeye
Copy link
Copy Markdown
Author

@mrodm we still had size required in the package-spec: I've changed it in elastic/package-spec#639

it would be better to include in v3.0.0 of the spec

since the only use of size is currently only in the elastic-package and package-spec itself if think it's safe to not have a code handling the migration, what do you think?

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Oct 18, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update system benchmark to use totEvents and drop deprecated size field from package-spec

2 participants