Unit test corpusgenerator#1267
Merged
francescayeye merged 3 commits intoelastic:mainfrom May 22, 2023
Merged
Conversation
2 tasks
Collaborator
💚 Build Succeeded
History
cc @aspacca |
mrodm
approved these changes
May 18, 2023
Contributor
mrodm
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding this unit test 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'll soon release a new version of the corpus generator tool
the the signature of the function used from the dependency didn't change:
new
v0.5.0
just the last
uint64has a different meaning, so nothing will break: just the number of events generated will be differenthere we add a unit test to check the expected number of events so when dependabot will create the PR for the bump will fail