Add more skipped directories when copying package files#1153
Add more skipped directories when copying package files#1153mrodm merged 1 commit intoelastic:mainfrom
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
ruflin
left a comment
There was a problem hiding this comment.
LGTM. Did run on this branch and now everything works as expected. As side effect seems also to be that now the build command is faster which can be explained if less files have to be copoied.
One general issue that seems to persist is that it copies all files in my .gitignore files and even adds them to the package. For example my .idea files are in there which I didn't intend to share :-)
Lets get this in but I think it is a topic that needs further discussion as packages will accidentally contain files which users did not expect to be in there.
Fixes #1154
This PR adds the following folders to be considered skipped when building the package:
.gitbuildThis is needed when the package files are directly located in the root of the repository.
As it is now,
elastic-package buildcommand copies all the folders/files except_dev. As thebuildfolder is created in the root of the repository (same as other package files) it is also copied to thebuildfolder again..gitfolder would be also copied along with the others.