Skip to content

Ignore missing files while loading profiles metadata#1006

Merged
jsoriano merged 1 commit intoelastic:mainfrom
jsoriano:ignore-missing-profile-files
Oct 17, 2022
Merged

Ignore missing files while loading profiles metadata#1006
jsoriano merged 1 commit intoelastic:mainfrom
jsoriano:ignore-missing-profile-files

Conversation

@jsoriano
Copy link
Copy Markdown
Member

@jsoriano jsoriano commented Oct 17, 2022

While loading profiles, ignore missing files. These errors can be caused by old or corrupted profiles, and shouldn't prevent elastic-package to read the rest of the profile or its metadata.

Fixes #881.
Solves the part of #589 about broken profiles list.

While loading profiles, ignore missing files. These errors can
be caused by old or corrupted profiles, and shouldn't prevent
elastic-package to read the rest of the profile or its metadata.
@jsoriano jsoriano requested a review from a team October 17, 2022 14:40
@jsoriano jsoriano self-assigned this Oct 17, 2022
@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-17T14:40:48.940+0000

  • Duration: 28 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 837
Skipped 0
Total 837

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown
Collaborator

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (35/35) 💚
Files 65.891% (85/129) 👍
Classes 60.87% (112/184) 👍
Methods 47.306% (360/761) 👍
Lines 30.519% (3246/10636) 👎 -0.009
Conditionals 100.0% (0/0) 💚

Copy link
Copy Markdown
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Profiles without cert files cannot be listed

3 participants