-
Notifications
You must be signed in to change notification settings - Fork 133
Open
Labels
Team:EcosystemLabel for the Packages Ecosystem teamLabel for the Packages Ecosystem teamtechnnical debt
Description
In #3213 a new elastic-package modify command has been added into elastic-package that required to create new internal packages (fleetpkg and yamledit).
There are some structs in fleetpkg that look similar to others already defined in elastic-package-
For instance:
Manifestinfleetpkg(https://github.com/elastic/elastic-package/pull/3213/changes#diff-7880dbca868888be0062a986f730fcbb094076bd95f397070f6e068e83c142b5R31) andPackageManifestinpackages()elastic-package/internal/packages/packages.go
Line 198 in 1c096f5
type PackageManifest struct { Datastreaminfleetpkg(https://github.com/elastic/elastic-package/pull/3213/changes#diff-7880dbca868888be0062a986f730fcbb094076bd95f397070f6e068e83c142b5R52) andDatastreamManifestinpackages()elastic-package/internal/packages/packages.go
Line 243 in ba9289e
type DataStreamManifest struct {
Refactor those structs from fleetpkg if possible to use existing structs in packages package. To be checked if there could be breaking changes.
Related thread: #3213 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Team:EcosystemLabel for the Packages Ecosystem teamLabel for the Packages Ecosystem teamtechnnical debt