Add comment for not returning uninstall error

mrodm · mrodm · commit 6e0af5e22b72 · 2023-06-20T17:05:46.000+02:00
diff --git a/internal/testrunner/runners/system/runner.go b/internal/testrunner/runners/system/runner.go
@@ -500,6 +500,8 @@ func (r *runner) runTest(config *testConfig, ctxt servicedeployer.ServiceContext
 		// by default system package is part of an agent policy and it cannot be uninstalled
 		// https://github.com/elastic/elastic-package/blob/5f65dc29811c57454bc7142aaf73725b6d4dc8e6/internal/stack/_static/kibana.yml.tmpl#L62
 		if err != nil && pkgManifest.Name != "system" {
+			// logging the error as a warning and not returning it since there could be other reasons that could make fail this process
+			// for instance being defined a test agent policy where this package is used for debugging purposes
 			logger.Warnf("failed to uninstall package %q: %s", pkgManifest.Name, err.Error())
 		}
 		return nil

Original file line number	Diff line number	Diff line change
`@@ -500,6 +500,8 @@ func (r runner) runTest(config testConfig, ctxt servicedeployer.ServiceContext`
`500`	`500`	`// by default system package is part of an agent policy and it cannot be uninstalled`
`501`	`501`	`// https://github.com/elastic/elastic-package/blob/5f65dc29811c57454bc7142aaf73725b6d4dc8e6/internal/stack/_static/kibana.yml.tmpl#L62`
`502`	`502`	`if err != nil && pkgManifest.Name != "system" {`
	`503`	`+ // logging the error as a warning and not returning it since there could be other reasons that could make fail this process`
	`504`	`+ // for instance being defined a test agent policy where this package is used for debugging purposes`
`503`	`505`	`logger.Warnf("failed to uninstall package %q: %s", pkgManifest.Name, err.Error())`
`504`	`506`	`}`
`505`	`507`	`return nil`