refactor: add manual sorting for tooltip, legend and rendering#924
Merged
markov00 merged 20 commits intoelastic:masterfrom Jan 25, 2021
Merged
refactor: add manual sorting for tooltip, legend and rendering#924markov00 merged 20 commits intoelastic:masterfrom
markov00 merged 20 commits intoelastic:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #924 +/- ##
==========================================
+ Coverage 70.85% 70.90% +0.05%
==========================================
Files 346 350 +4
Lines 11008 11072 +64
Branches 2424 2437 +13
==========================================
+ Hits 7800 7851 +51
- Misses 3195 3208 +13
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nickofthyme
reviewed
Nov 30, 2020
markov00
commented
Jan 10, 2021
markov00
commented
Jan 10, 2021
nickofthyme
reviewed
Jan 21, 2021
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
Reviewed all the code and have a few comments. Looking at the screenshots and storybook next.
src/chart_types/xy_chart/state/selectors/get_tooltip_values_highlighted_geoms.ts
Outdated
Show resolved
Hide resolved
nickofthyme
approved these changes
Jan 21, 2021
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
All screenshots and storybook stories look good 🎉
Collaborator
Author
|
🎉 This PR is included in version 24.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #303
Adds a way to sort tooltip, legend and rendered series via chart specification:
The API is currently hidden and not exposed to the final consumer to allow us cleaning this feature once we have found a better type for the SeriesIdentifier.
Although the API is hidden, you can ignore ts errors and using it at your own risk using the following hidden API and types:
An example of usage is:
Notes
The VRTs changes are changes only to the orders of elements in the legend and tooltip