feat: allow serialization of complex values#837
Closed
nickofthyme wants to merge 4 commits intoelastic:masterfrom
Closed
feat: allow serialization of complex values#837nickofthyme wants to merge 4 commits intoelastic:masterfrom
nickofthyme wants to merge 4 commits intoelastic:masterfrom
Conversation
|
Pretty cool :) cc @dej611 This will simplify the logic in the Lens xy chart renderer because we don't have to map back from the serialized x value (once we start using it of course) |
Collaborator
Author
|
Closing this issue to use Currently the return (
<BarSeries
id="bars"
xScaleType={ScaleType.Ordinal}
yScaleType={ScaleType.Linear}
xAccessor={({ obj: { from, to }}) => `${from} - ${to}`}
yAccessors={['y']}
data={[
{ y: 2, obj: { from: 10, to: 20 } },
{ y: 7, obj: { from: 20, to: 30 } },
{ y: 3, obj: { from: 30, to: 40 } },
{ y: 6, obj: { from: 40, to: 50 } },
]}
/>
) |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #808
Allows non-primative values to be passed through a serializer. Allows different serializer function for each series on all non-primative
x,yandmarkaccessor values.Checklist
src/index.ts(and stories only import from../srcexcept for test data & storybook)