refactor: decouple the brush component from XY chart#821
Merged
markov00 merged 3 commits intoelastic:masterfrom Sep 15, 2020
Merged
refactor: decouple the brush component from XY chart#821markov00 merged 3 commits intoelastic:masterfrom
markov00 merged 3 commits intoelastic:masterfrom
Conversation
nickofthyme
approved these changes
Sep 15, 2020
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
LGTM, tested brush stories locally on chrome and appear unaffected by changes.
Co-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>
Collaborator
Author
|
🎉 This PR is included in version 21.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR decouple the brush rendering component from the XY axis chart. This can be then reused by heatmap that requires this feature.
I've added a set of more specific methods on the
InternalChartStateinterface to decouple the implementation of each single chart related to chart dimensions and brush area computation.I've just skipped the implementation of these methods in Partition and Goal charts.
Right now the brush area is just a rect, but we can extend that to be whatever we need.