Skip to content

fix: hide series in tooltip#415

Merged
nickofthyme merged 4 commits intoelastic:feat/series-identifiersfrom
rshen91:tooltip-325
Oct 16, 2019
Merged

fix: hide series in tooltip#415
nickofthyme merged 4 commits intoelastic:feat/series-identifiersfrom
rshen91:tooltip-325

Conversation

@rshen91
Copy link
Copy Markdown
Contributor

@rshen91 rshen91 commented Oct 10, 2019 •
edited by nickofthyme
Loading

Summary

Start renaming GeometryId

Merging to feature branch to add SeriesIdentifier to all the things.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility, including a check against IE11
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

@nickofthyme nickofthyme requested a review from markov00 October 11, 2019 17:39
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 14, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (feat/series-identifiers@a1725e4). Click here to learn what that means.
The diff coverage is 98.18%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##             feat/series-identifiers     #415   +/-   ##
==========================================================
  Coverage                           ?   98.06%           
==========================================================
  Files                              ?       39           
  Lines                              ?     2846           
  Branches                           ?      677           
==========================================================
  Hits                               ?     2791           
  Misses                             ?       50           
  Partials                           ?        5
Impacted Files Coverage Δ
...rt_types/xy_chart/utils/nonstacked_series_utils.ts 100% <ø> (ø)
src/chart_types/xy_chart/store/utils.ts 96.7% <ø> (ø)
...chart_types/xy_chart/utils/stacked_series_utils.ts 98.21% <ø> (ø)
src/chart_types/xy_chart/utils/specs.ts 100% <ø> (ø)
src/chart_types/xy_chart/utils/interactions.ts 100% <100%> (ø)
src/chart_types/xy_chart/utils/series_utils.ts 100% <100%> (ø)
src/chart_types/xy_chart/utils/series.ts 100% <100%> (ø)
src/chart_types/xy_chart/tooltip/tooltip.ts 93.84% <100%> (ø)
src/chart_types/xy_chart/store/chart_state.ts 97.46% <100%> (ø)
src/utils/data_samples/test_dataset.ts 100% <100%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1725e4...28fb800. Read the comment docs.

@rshen91 rshen91 changed the base branch from master to feat/series-identifiers October 16, 2019 19:11
@nickofthyme nickofthyme marked this pull request as ready for review October 16, 2019 21:44
@nickofthyme nickofthyme merged commit 157ecce into elastic:feat/series-identifiers Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markov00 markov00 Awaiting requested review from markov00

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rshen91 @codecov-io @nickofthyme