Skip to content

chore: remove chrome bug logic from #1067#2417

Merged
nickofthyme merged 3 commits intoelastic:mainfrom
nickofthyme:remove-chrome-bug
Apr 26, 2024
Merged

chore: remove chrome bug logic from #1067#2417
nickofthyme merged 3 commits intoelastic:mainfrom
nickofthyme:remove-chrome-bug

Conversation

@nickofthyme
Copy link
Copy Markdown
Collaborator

@nickofthyme nickofthyme commented Apr 26, 2024

Summary

This PR removes code added in #1067 to fix a chromium bug affecting filling of area paths with sharp corners. This issues has since been fixed for over 6 months now.

Issues

fixes #2279

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The code has been checked for cross-browser compatibility (Chrome, Firefox, Safari, Edge)
  • Visual changes have been tested with light and dark themes

@nickofthyme nickofthyme added :all Applies to all chart types :rendering Rendering related issues labels Apr 26, 2024
@nickofthyme
Copy link
Copy Markdown
Collaborator Author

buildkite update screenshots

Copy link
Copy Markdown
Collaborator Author

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all due to minor shift of 0.5 px to y1 scaled values.

Looking at the change in the story below shows the issue has been resolved.

image

@nickofthyme nickofthyme merged commit 8acaf26 into elastic:main Apr 26, 2024
@nickofthyme nickofthyme deleted the remove-chrome-bug branch April 26, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:all Applies to all chart types :rendering Rendering related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert Chrome bug workaround

1 participant