Skip to content

feat: expose NaN values to tooltips#1206

Closed
markov00 wants to merge 4 commits intoelastic:masterfrom
markov00:2021_06_15-expose_all_data_to_tooltip
Closed

feat: expose NaN values to tooltips#1206
markov00 wants to merge 4 commits intoelastic:masterfrom
markov00:2021_06_15-expose_all_data_to_tooltip

Conversation

@markov00
Copy link
Copy Markdown
Collaborator

@markov00 markov00 commented Jun 16, 2021

Summary

Screenshot 2021-06-16 at 17 37 43

Details

Issues

close #950

Checklist

  • The proper chart type label was added (e.g. :xy, :partition) if the PR involves a specific chart type
  • The proper feature label was added (e.g. :interactions, :axis) if the PR involves a specific chart feature
  • Whenever possible, please check if the closing issue is connected to a running GH project
  • Any consumer-facing exports were added to packages/charts/src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios

@nickofthyme
Copy link
Copy Markdown
Collaborator

Is this to be closed in favor of #1226?

@markov00
Copy link
Copy Markdown
Collaborator Author

Is this to be closed in favor of #1226?

I'd like to keep this open because I've done few improvement in this PR that I like to keep

@nickofthyme nickofthyme force-pushed the master branch 7 times, most recently from 7148acf to 604b153 Compare September 13, 2021 04:06
@markov00 markov00 closed this Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to show tooltip for empty buckets

2 participants