Skip to content

chore(wordcloud): remove tooltip#1092

Merged
monfera merged 2 commits intoelastic:masterfrom
Kati-dev-hu:wordcloud-no-tooltip
Mar 29, 2021
Merged

chore(wordcloud): remove tooltip#1092
monfera merged 2 commits intoelastic:masterfrom
Kati-dev-hu:wordcloud-no-tooltip

Conversation

@Kati-dev-hu
Copy link
Copy Markdown
Contributor

Summary

Closes #1083

@kibanamachine
Copy link
Copy Markdown

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@Kati-dev-hu
Copy link
Copy Markdown
Contributor Author

jenkins please test this

1 similar comment
@monfera
Copy link
Copy Markdown
Contributor

monfera commented Mar 27, 2021

jenkins please test this

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 27, 2021

Codecov Report

Merging #1092 (1656a92) into master (2a8bd89) will increase coverage by 0.56%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1092      +/-   ##
==========================================
+ Coverage   71.71%   72.27%   +0.56%     
==========================================
  Files         383      397      +14     
  Lines       11924    12213     +289     
  Branches     2590     2616      +26     
==========================================
+ Hits         8551     8827     +276     
- Misses       3342     3347       +5     
- Partials       31       39       +8     
Flag Coverage Δ
unittests 71.85% <57.14%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/chart_types/wordcloud/state/chart_state.tsx 56.14% <57.14%> (-1.49%) ⬇️
src/mocks/utils.ts 100.00% <0.00%> (ø)
src/mocks/theme.ts 86.66% <0.00%> (ø)
src/mocks/series/series.ts 91.22% <0.00%> (ø)
src/mocks/geometries.ts 92.85% <0.00%> (ø)
src/mocks/specs/index.ts 100.00% <0.00%> (ø)
src/mocks/scale/scale.ts 77.77% <0.00%> (ø)
src/mocks/annotations/annotations.ts 66.66% <0.00%> (ø)
src/mocks/series/utils.ts 100.00% <0.00%> (ø)
src/mocks/series/index.ts 100.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58e6b5f...1656a92. Read the comment docs.

@monfera monfera added the :wordcloud Wordcloud related issues label Mar 27, 2021
@monfera monfera requested a review from markov00 March 27, 2021 09:47
Copy link
Copy Markdown
Collaborator

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for that.
I think we should disable (returning empty/false values) to the following methods:
isTooltipVisible and getTooltipInfo on the chart_state.tsx

@monfera
Copy link
Copy Markdown
Contributor

monfera commented Mar 28, 2021

jenkins please test this

Copy link
Copy Markdown
Collaborator

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks again Kati really appreciated it!

@monfera monfera merged commit f2e9259 into elastic:master Mar 29, 2021
@nickofthyme
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 27.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Issue released publicly :wordcloud Wordcloud related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Wordcloud] follow-up steps

6 participants