feat(api): cleanup exposed types#593
Merged
markov00 merged 5 commits intoelastic:masterfrom Mar 18, 2020
Merged
Conversation
This commit removes all the exposed type definition of the library to cleanup the public API
e941428 to
f59c884
Compare
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
==========================================
- Coverage 70.63% 70.55% -0.08%
==========================================
Files 220 220
Lines 6409 6412 +3
Branches 1228 1186 -42
==========================================
- Hits 4527 4524 -3
- Misses 1863 1869 +6
Partials 19 19
Continue to review full report at Codecov.
|
rshen91
approved these changes
Mar 18, 2020
Contributor
rshen91
left a comment
There was a problem hiding this comment.
LGTM thanks for doing this and adding a script in the package.json to make sure we add @internal to future code that doesn't need to be public 💪
markov00
pushed a commit
that referenced
this pull request
Mar 18, 2020
# [18.1.0](v18.0.0...v18.1.0) (2020-03-18) ### Bug Fixes * add unicorn eslint as dev dependency ([#591](#591)) ([30fd07c](30fd07c)) ### Features * remove duplicate tick labels from axis ([#577](#577)) ([e8c89ec](e8c89ec)), closes [#445](#445) * **api:** cleanup exposed types ([#593](#593)) ([544b7cc](544b7cc)) * **partition:** general sunburst via slice show control ([#592](#592)) ([5e6a30b](5e6a30b))
Collaborator
Author
|
🎉 This PR is included in version 18.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
Collaborator
Author
|
🎉 This PR is included in version 18.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [18.1.0](elastic/elastic-charts@v18.0.0...v18.1.0) (2020-03-18) ### Bug Fixes * add unicorn eslint as dev dependency ([opensearch-project#591](elastic/elastic-charts#591)) ([7c7ccfe](elastic/elastic-charts@7c7ccfe)) ### Features * remove duplicate tick labels from axis ([opensearch-project#577](elastic/elastic-charts#577)) ([52c6921](elastic/elastic-charts@52c6921)), closes [opensearch-project#445](elastic/elastic-charts#445) * **api:** cleanup exposed types ([opensearch-project#593](elastic/elastic-charts#593)) ([0b964c6](elastic/elastic-charts@0b964c6)) * **partition:** general sunburst via slice show control ([opensearch-project#592](elastic/elastic-charts#592)) ([7240823](elastic/elastic-charts@7240823))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes all the exposed type definitions that are not public, cleaning the API to the only public ones
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts(and stories only import from../srcexcept for test data & storybook)