fix(highlighter): clip path unique id#490
Merged
markov00 merged 3 commits intoelastic:masterfrom Dec 12, 2019
Merged
Conversation
To uniquely identify the clipPath for the highlighter in a multi-chart page, this commit add the chartId to the clipPath id fix elastic#489
Codecov Report
@@ Coverage Diff @@
## master #490 +/- ##
==========================================
+ Coverage 83.82% 83.83% +0.01%
==========================================
Files 158 169 +11
Lines 4723 4875 +152
Branches 961 979 +18
==========================================
+ Hits 3959 4087 +128
- Misses 749 772 +23
- Partials 15 16 +1
Continue to review full report at Codecov.
|
monfera
approved these changes
Dec 12, 2019
Contributor
monfera
left a comment
There was a problem hiding this comment.
🎉 Looks great and does what the PR says, indeed these things need to be globally unique on the page, and the chartId is unique due to using uuid
Collaborator
Author
|
🎉 This PR is included in version 15.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 tasks
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [15.0.4](elastic/elastic-charts@v15.0.3...v15.0.4) (2019-12-12) ### Bug Fixes * **highlighter:** clip path unique id ([opensearch-project#490](elastic/elastic-charts#490)) ([896b93e](elastic/elastic-charts@896b93e)), closes [opensearch-project#489](elastic/elastic-charts#489)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fix the issue of having multiple id with the same value for the highlighter clip path. This commit add the unique
chartIdto the clipPath id.fix #489
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any consumer-facing exports were added tosrc/index.ts(and stories only import from../srcexcept for test data & storybook)[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Proper documentation or storybook story was added for features that require explanation or tutorials