Skip to content

fix(legend): item hideInLegend prop#307

Merged
nickofthyme merged 1 commit intoelastic:masterfrom
nickofthyme:fix/hide-in-legend
Aug 13, 2019
Merged

fix(legend): item hideInLegend prop#307
nickofthyme merged 1 commit intoelastic:masterfrom
nickofthyme:fix/hide-in-legend

Conversation

@nickofthyme
Copy link
Copy Markdown
Collaborator

@nickofthyme nickofthyme commented Aug 13, 2019

Summary

Fix hideInLegend prop to work again

fix #306 -- I saw another issue for this a few weeks back but couldn't find it.

Before

Screen Recording 2019-08-12 at 07 49 PM

After

Screen Recording 2019-08-12 at 07 50 PM

Checklist

  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

@nickofthyme
fix(legend): item hideInLegend prop
55586dd 
Fix hideInLegend prop to work again

fix elastic#306
@nickofthyme nickofthyme requested a review from markov00 August 13, 2019 00:57
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 13, 2019 •
edited
Loading

Codecov Report

Merging #307 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #307   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files          37       37           
  Lines        2684     2684           
  Branches      632      632           
=======================================
  Hits         2635     2635           
  Misses         44       44           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 305a3bc...55586dd. Read the comment docs.

markov00
markov00 approved these changes Aug 13, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@markov00
Copy link
Copy Markdown
Collaborator

markov00 commented Aug 13, 2019

I saw another issue for this a few weeks back but couldn't find it.
was Caroline on slack. I don't think we have other issues for that.

BTW I've a linked feature request:
hideInLegend option for splitted series :D This one works with the full component, but a series component can made up of multiple splitted series, that someone want to hide independently on the legend. I think that should go with the whole customEverything ideas here #298 (comment)

@nickofthyme
Copy link
Copy Markdown
Collaborator Author

nickofthyme commented Aug 13, 2019

@markov00 sounds good 👍

@nickofthyme nickofthyme merged commit 3aa5ca3 into elastic:master Aug 13, 2019
@nickofthyme nickofthyme deleted the fix/hide-in-legend branch August 13, 2019 14:13
markov00 pushed a commit that referenced this pull request Aug 13, 2019
@semantic-release-bot
chore(release): 9.0.4 [skip ci]
d24a852 
## [9.0.4](v9.0.3...v9.0.4) (2019-08-13)

### Bug Fixes

* **legend:** item hideInLegend prop ([#307](#307)) ([3aa5ca3](3aa5ca3)), closes [#306](#306)
@markov00
Copy link
Copy Markdown
Collaborator

markov00 commented Aug 13, 2019

🎉 This PR is included in version 9.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Aug 13, 2019
@alexwizp alexwizp mentioned this pull request Aug 19, 2019
Merged
7 tasks
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 9.0.4 [skip ci]
42d95b6 
## [9.0.4](elastic/elastic-charts@v9.0.3...v9.0.4) (2019-08-13)

### Bug Fixes

* **legend:** item hideInLegend prop ([opensearch-project#307](elastic/elastic-charts#307)) ([fdfc694](elastic/elastic-charts@fdfc694)), closes [opensearch-project#306](elastic/elastic-charts#306)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markov00 markov00 markov00 approved these changes

Assignees

No one assigned

Labels

released Issue released publicly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

hideInLegend doesn't work

3 participants

@nickofthyme @codecov-io @markov00