Skip to content

Remove axis strict render checks #2187

@nickofthyme

Description

@nickofthyme

Describe the issue

When the different parts of the axis are rendered we first check if it is necessary to render each part. For example a line of width 0 is not necessary to render. However, this causes problems for users when attempting to set the padding forcing them to fudge the rendering just to add the padding.

There are several usages in kibana of users forcing these styles:

const style = {
  tickLine: { size: 0.0001, padding: 4, visible: true },
}

To Reproduce
Steps to reproduce the behavior:

  1. Go to this story
  2. Set any of the axis tickLine sizes to 0
  3. Notice the entire line, including padding, is removed from rendering

Expected behaviour

The rendering of axes properties should be solely driven by the visible prop.

Screenshots
image

Metadata

Metadata

Assignees

Labels

:axisAxis related issuebugSomething isn't working

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions