Per discussions from #865, we have determined to go ahead with moving the charts theme from eui back to charts.
Action items for EUI
Font family
Resolve which font family to use for charts theme? Currently the eui charts theme
defines the fontFamily here as...
const fontFamily = `'Inter', 'Inter UI', -apple-system, BlinkMacSystemFont, 'Segoe UI', Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol'`;
but the eui theme JSON defines three font families as...
I assume for charts we want to use theme.font.family, needs confirmation.
Export colors
Export computed theme colors here to either the theme JSON or a separate colors-only JSON distributable for dark and light themes.
Action items for charts
Update existing charts theme
Update the charts theme to conform to the current eui chart theme defaults found here. This includes importing the colors and fontFamily from eui JSON and/or palette functions. Also need to append the colors with chartLines and chartBand defined per theme here.
Final logistical steps
Future tasks
Handle dynamic theme changes
Possibly by creating a global charts provider in kibana to update theming based on changes to EuiProvider base theming.
Migrate away from eui sass
Charts currently relies on several sass files from eui (see _eui_imports.scss) to match basic styles from eui. These include variables, functions and mixins.
Need to discuss how to resolve this - possible options are:
- Duplicate functionality in charts.
- Use custom chart styles to get close.
- Somehow use eui emotion styles in charts (Migrate chart styles to pure javascript).
Per discussions from #865, we have determined to go ahead with moving the charts theme from eui back to charts.
Action items for EUI
Font family
Resolve which font family to use for charts theme? Currently the eui charts theme
defines the
fontFamilyhere as...but the eui theme JSON defines three font families as...
{ ... "font": { "family": "'Inter', BlinkMacSystemFont, Helvetica, Arial, sans-serif", "familyCode": "'Roboto Mono', Menlo, Courier, monospace", "familySerif": "Georgia, Times, Times New Roman, serif", ... } }I assume for charts we want to use
theme.font.family, needs confirmation.Export colors
Export computed theme colors here to either the theme JSON or a separate colors-only JSON distributable for dark and light themes.
Action items for charts
Update existing charts theme
Update the charts theme to conform to the current eui chart theme defaults found here. This includes importing the colors and
fontFamilyfrom eui JSON and/or palette functions. Also need to append the colors withchartLinesandchartBanddefined per theme here.Final logistical steps
Future tasks
Handle dynamic theme changes
Possibly by creating a global charts provider in kibana to update theming based on changes to
EuiProviderbase theming.Migrate away from eui sass
Charts currently relies on several sass files from eui (see
_eui_imports.scss) to match basic styles from eui. These include variables, functions and mixins.Need to discuss how to resolve this - possible options are: