Skip to content

Commit fca6cdd

Browse files
nickofthymenickofthyme
authored
feat(bullet): new design style and implementation (#2156)
1 parent 881de86 commit fca6cdd

218 files changed

Lines changed: 4136 additions & 173 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.eslintrc.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ module.exports = {
6969
'@typescript-eslint/no-unsafe-call': 0, // seems to have issues with default import types
7070
'@typescript-eslint/unbound-method': 1,
7171
'@typescript-eslint/no-redeclare': 0, // we use to declare enum type and object with the same name
72-
'@typescript-eslint/no-shadow': 0, // we use shadow mostly within the canvas renderer function when we need a new context
72+
'@typescript-eslint/no-shadow': 0,
7373
'@typescript-eslint/quotes': 0,
7474
'@typescript-eslint/no-unsafe-argument': 1,
7575
'unicorn/consistent-function-scoping': 1,
@@ -89,7 +89,7 @@ module.exports = {
8989
'unicorn/number-literal-case': 0, // use prettier lower case preference
9090
'global-require': 1,
9191
'import/no-dynamic-require': 1,
92-
'no-shadow': 1,
92+
'no-shadow': ['warn', { allow: ['ctx'] }], // allow replacing ctx in canvas renderer functions, too tedious to rename at each level
9393
'react/no-array-index-key': 1,
9494
'react/prefer-stateless-function': 1,
9595
'react/require-default-props': 0,

‎e2e/helpers.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export interface StoryGroupInfo {
3737
/**
3838
* Groups to skip in all vrt.
3939
*/
40-
const groupsToSkip: Set<string> = new Set(['Components/Tooltip']);
40+
const groupsToSkip: Set<string> = new Set(['Components/Tooltip', 'Bullet Graph']);
4141

4242
/**
4343
* Stories to skip in all vrt based by group.

‎e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-horizontal/bullet-as-metric/should-render-with-negative-values-chrome-linux.png‎

3.47 KB

‎e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-horizontal/bullet-as-metric/should-render-with-negative-values-reversed-chrome-linux.png‎

3.46 KB

‎e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-horizontal/bullet-as-metric/should-render-with-positive-negative-values-chrome-linux.png‎

3.04 KB

‎e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-horizontal/bullet-as-metric/should-render-with-positive-negative-values-reversed-chrome-linux.png‎

3.04 KB

‎e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-horizontal/bullet-as-metric/should-render-with-positive-values-chrome-linux.png‎

3.41 KB

‎e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-horizontal/bullet-as-metric/should-render-with-positive-values-reversed-chrome-linux.png‎

3.41 KB

‎e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-two-thirds-circle/bullet-as-metric/should-render-with-negative-values-chrome-linux.png‎

5.55 KB

‎e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-two-thirds-circle/bullet-as-metric/should-render-with-negative-values-reversed-chrome-linux.png‎

5.55 KB

0 commit comments

Comments
 (0)