fix(axis): always render tickLine unless visible is false (#2194)

nickofthyme · web-flow · commit ec95d50180d8 · 2023-10-10T15:43:59.000-07:00
BREAKING CHANGE: Now respects `tickLine.padding` whenever `tickLine.visible` is `true`
diff --git a/packages/charts/src/chart_types/xy_chart/annotations/rect/dimensions.ts b/packages/charts/src/chart_types/xy_chart/annotations/rect/dimensions.ts
@@ -243,10 +243,8 @@ function maxOf(base: number, value: number | string | null | undefined): number
   return typeof value === 'number' ? Math.max(value, base) : typeof value === 'string' ? value : base;
 }
 
-function getOutsideDimension(style: AxisStyle): number {
-  const { visible, size, strokeWidth } = style.tickLine;
-
-  return visible && size > 0 && strokeWidth > 0 ? size : 0;
+function getOutsideDimension({ tickLine: { visible, size } }: AxisStyle): number {
+  return visible ? size : 0;
 }
 
 /**
diff --git a/packages/charts/src/chart_types/xy_chart/utils/axis_utils.ts b/packages/charts/src/chart_types/xy_chart/utils/axis_utils.ts
@@ -24,7 +24,6 @@ import { Range } from '../../../utils/domain';
 import { AxisId } from '../../../utils/ids';
 import { Point } from '../../../utils/point';
 import { AxisStyle, TextAlignment, TextOffset, Theme } from '../../../utils/themes/theme';
-import { MIN_STROKE_WIDTH } from '../renderer/canvas/primitives/line';
 import { Projection } from '../state/selectors/visible_ticks';
 import { SeriesDomainsAndData } from '../state/utils/types';
 
@@ -291,8 +290,8 @@ export function getPosition(
 }
 
 /** @internal */
-export function shouldShowTicks({ visible, strokeWidth, size }: AxisStyle['tickLine'], axisHidden: boolean): boolean {
-  return !axisHidden && visible && size > 0 && strokeWidth >= MIN_STROKE_WIDTH;
+export function shouldShowTicks({ visible }: AxisStyle['tickLine'], axisHidden: boolean): boolean {
+  return !axisHidden && visible;
 }
 
 /** @internal */

Original file line number	Diff line number	Diff line change
`@@ -243,10 +243,8 @@ function maxOf(base: number, value: number \| string \| null \| undefined): number`
`243`	`243`	`return typeof value === 'number' ? Math.max(value, base) : typeof value === 'string' ? value : base;`
`244`	`244`	`}`
`245`	`245`
`246`		`-function getOutsideDimension(style: AxisStyle): number {`
`247`		`- const { visible, size, strokeWidth } = style.tickLine;`
`248`		`-`
`249`		`- return visible && size > 0 && strokeWidth > 0 ? size : 0;`
	`246`	`+function getOutsideDimension({ tickLine: { visible, size } }: AxisStyle): number {`
	`247`	`+ return visible ? size : 0;`
`250`	`248`	`}`
`251`	`249`
`252`	`250`	`/**`