Skip to content

Commit 4f1a0b1

Browse files
nickofthymenickofthyme
authored
feat(axis): improved axis styles (#711)
Axis improvements - Hide axis but show gridlines - hide axis titles, labels, ticks and line independently - add inner and outer padding to tick labels - add inner and outer padding to axes titles - transform offsets relative to local reference (i.e. rotated coordinates) - transform offsets relative to global reference - add tick label horizontal and vertical alignment closes #714, #312 BREAKING CHANGES property name changes: AxisSpec.gridLineStyle => AxisSpec.gridLine AxisSpec.gridLineStyle => AxisSpec.gridLine type changes: AxisSpec.tickLabelRotation => AxisStyle.tickLabel.rotation AxisSpec.tickPadding => AxisStyle.tickLine.padding AxisSpec.tickSize => AxisStyle.tickLine.size AxisStyle.tickLabelPadding => AxisStyle.tickLabel.padding GridLineConfig => GridLineStyle AxisSpec.style => RecursivePartial<AxisStyle> (new AxisStyle type) AxisConfig.axisLineStyle => AxisStyle.axisLine AxisConfig.axisTitleStyle => AxisStyle.axisTitle AxisConfig.tickLabelStyle => AxisStyle.tickLabel AxisConfig.tickLineStyle => AxisStyle.tickLine GridLineStyle requires all properties deprecate AxisSpec.showGridLines in favor of AxisSpec.gridLine.visible
1 parent ce4349f commit 4f1a0b1

338 files changed

Lines changed: 1277 additions & 597 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.eslintrc.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ module.exports = {
3434
'@typescript-eslint/no-unsafe-return': 0,
3535
'@typescript-eslint/explicit-module-boundary-types': 0,
3636
'@typescript-eslint/restrict-template-expressions': 1,
37-
'@typescript-eslint/restrict-plus-operands': 1,
37+
'@typescript-eslint/restrict-plus-operands': 0, // rule is broken
3838
'@typescript-eslint/no-unsafe-call': 1,
3939
'@typescript-eslint/unbound-method': 1,
4040
'unicorn/consistent-function-scoping': 1,

‎api/charts.api.md‎

Lines changed: 85 additions & 43 deletions

‎integration/helpers.ts‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,15 +72,18 @@ function encodeString(string: string) {
7272
*/
7373
const storiesToSkip: Record<string, string[]> = {
7474
// Interactions: ['Some story name'],
75+
Legend: [
76+
'Actions',
77+
],
7578
};
7679

7780
/**
7881
* Delays for stories to skip in all vrt based on group.
7982
*/
8083
const storiesToDelay: Record<string, Record<string, number>> = {
81-
Legend: {
82-
Actions: 200, // needed for icon to load
83-
},
84+
// GroupName: {
85+
// 'some story name': 200,
86+
// },
8487
};
8588

8689
export function getStorybookInfo(): StoryGroupInfo[] {

‎integration/tests/__image_snapshots__/all-test-ts-baseline-visual-tests-for-all-stories-annotations-lines-single-bar-histogram-visually-looks-correct-1-snap.png‎

-29 Bytes

‎integration/tests/__image_snapshots__/all-test-ts-baseline-visual-tests-for-all-stories-annotations-lines-styling-visually-looks-correct-1-snap.png‎

-290 Bytes

‎integration/tests/__image_snapshots__/all-test-ts-baseline-visual-tests-for-all-stories-annotations-lines-tooltip-options-visually-looks-correct-1-snap.png‎

-140 Bytes

‎integration/tests/__image_snapshots__/all-test-ts-baseline-visual-tests-for-all-stories-annotations-lines-x-continuous-domain-visually-looks-correct-1-snap.png‎

-149 Bytes

‎integration/tests/__image_snapshots__/all-test-ts-baseline-visual-tests-for-all-stories-annotations-lines-x-ordinal-domain-visually-looks-correct-1-snap.png‎

-140 Bytes

‎integration/tests/__image_snapshots__/all-test-ts-baseline-visual-tests-for-all-stories-annotations-lines-x-time-domain-visually-looks-correct-1-snap.png‎

-469 Bytes

‎integration/tests/__image_snapshots__/all-test-ts-baseline-visual-tests-for-all-stories-annotations-lines-y-domain-visually-looks-correct-1-snap.png‎

-174 Bytes

0 commit comments

Comments
 (0)