fix: update fn to break early

nickofthyme · nickofthyme · commit 3c7c2f805b4d · 2020-12-03T10:49:23.000-06:00
diff --git a/src/chart_types/xy_chart/domains/x_domain.ts b/src/chart_types/xy_chart/domains/x_domain.ts
@@ -123,22 +123,23 @@ export function mergeXDomain(
   };
 }
 
-function getMinInterval(computedMinInterval: number, size: number, customMinInterval?: number) {
-  if (customMinInterval != null) {
-    // Allow greater custom min if xValues has 1 member.
-    if (size > 1 && customMinInterval > computedMinInterval) {
-      Logger.warn(
-        'custom xDomain is invalid, custom minInterval is greater than computed minInterval. Using computed minInterval.',
-      );
-      return computedMinInterval;
-    }
-    if (customMinInterval < 0) {
-      Logger.warn('custom xDomain is invalid, custom minInterval is less than 0. Using computed minInterval.');
-      return computedMinInterval;
-    }
+function getMinInterval(computedMinInterval: number, size: number, customMinInterval?: number): number {
+  if (customMinInterval == null) {
+    return computedMinInterval;
+  }
+  // Allow greater custom min if xValues has 1 member.
+  if (size > 1 && customMinInterval > computedMinInterval) {
+    Logger.warn(
+      'custom xDomain is invalid, custom minInterval is greater than computed minInterval. Using computed minInterval.',
+    );
+    return computedMinInterval;
+  }
+  if (customMinInterval < 0) {
+    Logger.warn('custom xDomain is invalid, custom minInterval is less than 0. Using computed minInterval.');
+    return computedMinInterval;
   }
 
-  return customMinInterval || computedMinInterval;
+  return customMinInterval;
 }
 
 /**
