fix(theme): legacy margins (#2262)

nickofthyme · web-flow · commit 299c869fec25 · 2023-11-29T10:47:41.000-07:00
diff --git a/packages/charts/src/utils/themes/legacy_dark_theme.ts b/packages/charts/src/utils/themes/legacy_dark_theme.ts
@@ -9,10 +9,10 @@
 import { palettes } from './colors';
 import { Theme } from './theme';
 import {
-  DEFAULT_CHART_MARGINS,
-  DEFAULT_CHART_PADDING,
   DEFAULT_GEOMETRY_STYLES,
   DEFAULT_MISSING_COLOR,
+  LEGACY_CHART_MARGINS,
+  LEGACY_CHART_PADDING,
 } from './theme_common';
 import { DARK_THEME_BULLET_STYLE } from '../../chart_types/bullet_graph/theme';
 import { Colors } from '../../common/colors';
@@ -26,8 +26,8 @@ import { ColorVariant } from '../common';
  * @deprecated Use new `DARK_THEME`
  */
 export const LEGACY_DARK_THEME: Theme = {
-  chartPaddings: DEFAULT_CHART_PADDING,
-  chartMargins: DEFAULT_CHART_MARGINS,
+  chartPaddings: LEGACY_CHART_PADDING,
+  chartMargins: LEGACY_CHART_MARGINS,
   lineSeriesStyle: {
     line: {
       visible: true,
diff --git a/packages/charts/src/utils/themes/legacy_light_theme.ts b/packages/charts/src/utils/themes/legacy_light_theme.ts
@@ -9,10 +9,10 @@
 import { palettes } from './colors';
 import { Theme } from './theme';
 import {
-  DEFAULT_CHART_MARGINS,
-  DEFAULT_CHART_PADDING,
   DEFAULT_GEOMETRY_STYLES,
   DEFAULT_MISSING_COLOR,
+  LEGACY_CHART_MARGINS,
+  LEGACY_CHART_PADDING,
 } from './theme_common';
 import { LIGHT_THEME_BULLET_STYLE } from '../../chart_types/bullet_graph/theme';
 import { Colors } from '../../common/colors';
@@ -26,8 +26,8 @@ import { ColorVariant } from '../common';
  * @deprecated use new `LIGHT_THEME`
  */
 export const LEGACY_LIGHT_THEME: Theme = {
-  chartPaddings: DEFAULT_CHART_PADDING,
-  chartMargins: DEFAULT_CHART_MARGINS,
+  chartPaddings: LEGACY_CHART_PADDING,
+  chartMargins: LEGACY_CHART_MARGINS,
   lineSeriesStyle: {
     line: {
       visible: true,
diff --git a/packages/charts/src/utils/themes/theme_common.ts b/packages/charts/src/utils/themes/theme_common.ts
@@ -28,6 +28,17 @@ export const DEFAULT_CHART_MARGINS: Margins = {
   bottom: 0,
 };
 
+/**
+ * Remove in next step to limit diffs
+ * @internal
+ */
+export const LEGACY_CHART_PADDING: Margins = {
+  left: 0,
+  right: 0,
+  top: 0,
+  bottom: 0,
+};
+
 /**
  * Remove in next step to limit diffs
  * @internal
