Add user data to monitoring setup#80
Merged
fearful-symmetry merged 1 commit intoelastic:mainfrom Mar 28, 2023
Merged
Conversation
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
7 tasks
cmacknz
approved these changes
Mar 28, 2023
Member
cmacknz
left a comment
There was a problem hiding this comment.
Make sure we remove the duplicated code from Beats if we can.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a simple PR that migrates the code that adds user data to the monitoring registry from beats to here. The original code is in
libbeat/cmd/instance/beat.go, and needs to be used in the shipper in order to bring the shipper up to feature parity with the beats in terms of monitoring. Just copy-and-pasting the user metrics is a bit ugly, so I figured I'd be better off migrating the metrics.Why is it important?
We want to reduce code duplication across beats.
Checklist
CHANGELOG.md