Merged
Conversation
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
6 tasks
leehinman
approved these changes
Sep 26, 2022
Contributor
leehinman
left a comment
There was a problem hiding this comment.
LGTM. couple spelling and capitalization suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is part of elastic/beats#33169
Specifically, This adds a public API that reports the state of a given PID, and a special error if a given process does not exist.
This is a bit of an awkward fix, since there's no "good" place for this API to go; This library is mainly for handling the complexities of the
system/processdataset, but it's only the library we have that reports process state.go-sysinfomight be a better fit for this, but there's no code for fetching process state there. So, for now, this is kind of the best we can do.Why is it important?
This is needed by elastic/beats#33169 so we can distinguish between zombie processes and other process types.
Checklist
CHANGELOG.md