Skip to content

bk: update junit-annotate to run faster#264

Merged
v1v merged 3 commits intomainfrom
copilot/fix-263
Sep 23, 2025
Merged

bk: update junit-annotate to run faster#264
v1v merged 3 commits intomainfrom
copilot/fix-263

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Sep 19, 2025 •
edited
Loading

This PR updates the Buildkite junit-annotate plugin configuration to use a faster container-based approach as requested in #263.

Changes Made

  • Plugin Version: Upgraded junit-annotate from v2.4.1 to v2.7.0
  • Agent Configuration: Replaced provider: "gcp" with container image docker.elastic.co/ci-agent-images/buildkite-junit-annotate:1.0
  • Execution Method: Added run-in-docker: false to the plugin configuration for faster execution
  • Documentation: Added comment noting requirements for bash, curl, and git

Configuration Changes

Before:

- label: ":junit: Junit annotate"
  plugins:
    - junit-annotate#v2.4.1:
        artifacts: "*.xml"
        fail-build-on-error: true
  agents:
    provider: "gcp"

After:

- label: ":junit: Junit annotate"
  agents:
    # requires at least "bash", "curl" and "git"
    image: "docker.elastic.co/ci-agent-images/buildkite-junit-annotate:1.0"
  plugins:
    - junit-annotate#v2.7.0:
        artifacts: "*.xml"
        fail-build-on-error: true
        run-in-docker: false

This change should significantly improve the speed of the junit annotation step by using a dedicated container instead of requiring a GCP provider instance.

Fixes #263.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI assigned Copilot and v1v Sep 19, 2025
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Sep 19, 2025

@v1v 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

Copilot AI requested a review from v1v September 19, 2025 15:58
@v1v
Copy link
Copy Markdown
Member

v1v commented Sep 19, 2025

@copilot finish the PR, it's still marked as WIP in the description

@v1v
Update junit-annotate to use faster container-based approach
8dfbb3d 
- Replace junit-annotate#v2.4.1 with v2.7.0
- Use docker.elastic.co/ci-agent-images/buildkite-junit-annotate:1.0 container
- Remove GCP provider requirement
- Add run-in-docker: false for faster execution

Co-authored-by: v1v <2871786+v1v@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Sep 19, 2025

@copilot finish the PR, it's still marked as WIP in the description

Done! I've completed the PR and removed the WIP status. The junit-annotate configuration has been updated to use the faster container-based approach as requested. Changes include upgrading to v2.7.0, using the docker.elastic.co/ci-agent-images/buildkite-junit-annotate:1.0 container, and adding run-in-docker: false. See commit 8dfbb3d.

Copilot AI changed the title [WIP] bk: update unit-annotate to run faster bk: update junit-annotate to run faster Sep 19, 2025
@v1v
Copy link
Copy Markdown
Member

v1v commented Sep 22, 2025

buildkite test it

@v1v v1v marked this pull request as ready for review September 22, 2025 10:48
@v1v v1v requested a review from a team as a code owner September 22, 2025 10:48
@v1v v1v requested review from a team, VihasMakwana and rdner and removed request for a team September 22, 2025 10:48
@v1v v1v enabled auto-merge (squash) September 22, 2025 10:48
fr4nc1sc0-r4m0n
fr4nc1sc0-r4m0n approved these changes Sep 22, 2025
View reviewed changes
Copy link
Copy Markdown

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v1v
Copy link
Copy Markdown
Member

v1v commented Sep 23, 2025

buildkite test this

@v1v v1v merged commit e160bde into main Sep 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana is a code owner automatically assigned from elastic/elastic-agent-data-plane

+1 more reviewer

@v1v v1v v1v approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@v1v v1v

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bk: update unit-annotate to run faster

3 participants

@v1v @fr4nc1sc0-r4m0n