fix: resolve index out of bounds in diskio stat#260
Merged
khushijain21 merged 1 commit intoelastic:mainfrom Aug 26, 2025
Merged
fix: resolve index out of bounds in diskio stat#260khushijain21 merged 1 commit intoelastic:mainfrom
khushijain21 merged 1 commit intoelastic:mainfrom
Conversation
it's possible on linux to get an empty slice if the file is empty protect against that by checking the slice len. It's impossible on darwin but let's not rely on implementation details and also check there.
mauri870
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
it's possible on linux to get an empty slice if the file is empty
protect against that by checking the slice len.
It's impossible on darwin but let's not rely on implementation details and also check there.
Why is it important?
prevent index out of bounds error
Checklist
CHANGELOG.mdAuthor's Checklist
Related issues