[system/process] add support for mutlierr #172
Merged
VihasMakwana merged 1 commit intomainfrom Aug 1, 2024
Merged
Conversation
This reverts commit 50700ed.
rdner
reviewed
Aug 1, 2024
Member
rdner
left a comment
There was a problem hiding this comment.
Due to the nature of the change, we need to perform manual tests in order to ensure the change works. Please add instructions for manual testing to ensure updating to the new version of this library would not break Beats.
7 tasks
Contributor
Author
|
@rdner I've added the beats PR link in description |
6 tasks
rdner
approved these changes
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checklist
CHANGELOG.mdManual testing and general information
metricbeatNOTE:
system/processmoduleSteps:
errors.Is(err, NonFatalErr{}))on received errorGenreal info related to the changes in this PR:
While getting process related information, you might also receive a non-nil error.
Such errors come in two flavours:
no process found,)not enough privileges).Closes [metric/system/process] - return errors encountered while monitoring set of processes #164