This repository was archived by the owner on Sep 21, 2023. It is now read-only.
Add Timestamp support in Struct of protobuf#69
Merged
rdner merged 5 commits intoelastic:mainfrom Jun 28, 2022
rdner:struct-timestamp
Merged
Add Timestamp support in Struct of protobuf#69rdner merged 5 commits intoelastic:mainfrom rdner:struct-timestamp
rdner merged 5 commits intoelastic:mainfrom
rdner:struct-timestamp
Conversation
Now we can send the Timestamp values without losing data and all the message definitions live in a separate package.
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
cmacknz
reviewed
Jun 28, 2022
cmacknz
reviewed
Jun 28, 2022
cmacknz
reviewed
Jun 28, 2022
cmacknz
approved these changes
Jun 28, 2022
Member
cmacknz
left a comment
There was a problem hiding this comment.
LGTM. Approving but make sure you clean up the comment suggesting we add a timestamp to Struct since this change does exactly that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we can send the Timestamp values without losing data and all the
message definitions live in a separate package.
Closes #62