This repository was archived by the owner on Sep 21, 2023. It is now read-only.
Add infinite retry, fix monitoring#296
Merged
fearful-symmetry merged 5 commits intoelastic:mainfrom Apr 18, 2023
Merged
Conversation
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
faec
approved these changes
Apr 18, 2023
Contributor
faec
left a comment
There was a problem hiding this comment.
Looks good, a few suggested cleanups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #262
This PR adds infinite retry functionality, and completely refactors the elasticsearch health monitor. In detail
max_retriesis set to-1, this enables "infinite" retry, which just sets the ES MaxRetries toMaxInt.OnFailure, the monitor instead watches the raw HTTP return codes coming from the elasticsearch transport, and checks the deltas.Why is it important?
We want infinite retry.
Checklist
CHANGELOG.mdorCHANGELOG-developer.md.How to test this PR locally
max_retriesto-1: