This repository was archived by the owner on Sep 21, 2023. It is now read-only.
Enable batch config settings in the ES output#227
Merged
faec merged 4 commits intoelastic:mainfrom Jan 30, 2023
Merged
Conversation
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
leehinman
approved these changes
Jan 26, 2023
Contributor
leehinman
left a comment
There was a problem hiding this comment.
LGTM
optional: might be nice to say what defaults for num_workers etc is, or at least how it gets derived.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
batch_sizeandflush_timeoutparameters to the Elasticsearch output (as well as a few others that were straightforward withgo-elasticsearch:num_workers,backoff,max_retries).Closes #28
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.mdorCHANGELOG-developer.md.