Skip to content
This repository was archived by the owner on Sep 21, 2023. It is now read-only.

Add support for codecs#170

Merged
robbavey merged 2 commits intoelastic:mainfrom
robbavey:codec_support
Nov 15, 2022
Merged

Add support for codecs#170
robbavey merged 2 commits intoelastic:mainfrom
robbavey:codec_support

Conversation

@robbavey
Copy link
Copy Markdown
Member

@robbavey robbavey commented Nov 9, 2022

This commit adds support for codecs in the configuration file with the same syntax and options as the beats kafka output.

This commit creates a BeatInfo object to pass into the existing codec object AFAICT, this only requires a version to populate metadata with.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.md or CHANGELOG-developer.md.

Closes #165

This commit adds support for codecs in the configuration file with the same
syntax and options as the beats kafka output.

This commit creates a `BeatInfo` object to pass into the existing codec object
AFAICT, this only requires a version to populate metadata with.
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 9, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @robbavey? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 9, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-15T15:11:46.477+0000

  • Duration: 17 min 57 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@robbavey robbavey marked this pull request as ready for review November 15, 2022 15:49
@robbavey robbavey requested a review from a team as a code owner November 15, 2022 15:49
@robbavey robbavey requested review from belimawr and cmacknz and removed request for a team November 15, 2022 15:49
@cmacknz cmacknz requested review from faec and leehinman November 15, 2022 16:05
@cmacknz cmacknz added the Team:Elastic-Agent Label for the Agent team label Nov 15, 2022
@robbavey robbavey merged commit 7bc1701 into elastic:main Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Team:Elastic-Agent Label for the Agent team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kafka output should support codecs

4 participants