Modify npipe to directly get the user SID#62
Merged
kvch merged 1 commit intoelastic:mainfrom Jun 13, 2022
Merged
Conversation
Remove the dependency on user.Current(). It fetches more information than is required to configure the named pipe. This only needs to know the SID in order to build the SDDL. This avoids the possibility of lengthy delays fetching the unnecessary metadata about the current user. Relates elastic/beats#31810 Porting over elastic/beats@1fcdee6
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
belimawr
approved these changes
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Porting over elastic/beats@1fcdee6
Remove the dependency on user.Current(). It fetches more information than
is required to configure the named pipe. This only needs to know the SID
in order to build the SDDL.
This avoids the possibility of lengthy delays fetching the unnecessary
metadata about the current user.
Relates elastic/beats#31810