Conversation
Contributor
Author
|
Build failure is unrelated; due to tool Go version dependency not being satisfied by specified Go version. |
belimawr
approved these changes
Apr 1, 2026
Expose the underlying zap Logger.Name method so callers can retrieve the logger's dot-joined name. This is needed to carry the logger name across when bridging to slog via zapslog.
Collaborator
💚 Build Succeeded
History
cc @efd6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the underlying zap Logger.Name method so callers can retrieve the logger's dot-joined name. This is needed to carry the logger name across when bridging to slog via zapslog.
What does this PR do?
It adds a call-through to the zap logger name method.
Why is it important?
This allows bridging to log/slog without loss of logger naming behaviour.
Checklist
Author's Checklist
Related issues