Add HTTPAuthorization settings to HTTPTransportSettings#386
Merged
michel-laterman merged 3 commits intoelastic:mainfrom Feb 24, 2026
Merged
Conversation
Collaborator
💚 Build Succeeded
History
|
michel-laterman
commented
Feb 18, 2026
belimawr
approved these changes
Feb 19, 2026
Contributor
belimawr
left a comment
There was a problem hiding this comment.
LGTM, but make sure @jillguyonnet is also happy with the current behaviour.
Contributor
Author
|
I'm going to hold off on merging this until elastic/go-ucfg#224 is merged so we can mark sensitive values as needing redaction; EDIT: |
This was referenced Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add auth settings struct to
HTTPTransportSettings.Auth struct contains username+password for basic auth, api_key, and custom headers. Setting any of these will inject the headers (as
Authorizationfor basic or api_key) into all requests made with a round tripper created from the settings.Related work in Kibana: elastic/kibana#250557
Why is it important?
Provide a way to configure the use of credentials to all requests.
Checklist
I have commented my code, particularly in hard-to-understand areas