Add domain socket/named pipe support#91
Merged
blakerouse merged 8 commits intoelastic:mainfrom Jan 16, 2024
Merged
Conversation
Contributor
|
@aleksmaus I haven't looked deeply at this, but I did notice that you aren't using https://github.com/elastic/elastic-agent-libs/tree/main/api , which is what the rest of elastic-agent uses for socket/named pipe support. Is there a reason we can't use that? |
Contributor
Author
@leehinman I replaced the direct calls to to winio with the github.com/elastic/elastic-agent-libs/api/npipe APIs. |
blakerouse
approved these changes
Jan 12, 2024
Contributor
blakerouse
left a comment
There was a problem hiding this comment.
Change looks good. Just a typo comment.
Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
This was referenced Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for elastic agent client comms over domain socket on *nix and named pipe on windows.
I saw there was a discussion on the agent channel that this would solve some of the issues seen with localhost ports blocked etc.
There is no changes to the interface signatures, it's still fully backwards compatible.
Added more tests to cover comms over domain sockets/named pipes with and without TLS.
Can update the agent/beats if this looks ok and work with Endpoint team to get er done.