Update the client protocol to new defined contract#2
Update the client protocol to new defined contract#2blakerouse merged 2 commits intoelastic:masterfrom
Conversation
| // Expects that the application is running. | ||
| RUNNING = 0; | ||
| // Expects that the application is stopping. | ||
| STOPPING = 1; |
There was a problem hiding this comment.
are we expecting it to be stopping or stopped, just a small detail
There was a problem hiding this comment.
Once stopped the application should be off and the GRPC should be disconnected at that point. So I was going with stopping which also goes with running both being -ing based.
elastic-agent-client.proto
Outdated
| // Index of the either current configuration or new configuration provided. | ||
| uint64 config_state_idx = 2; | ||
| // Resulting configuration. (If the application already has the current `config_state_idx` this | ||
| // with be empty.) |
There was a problem hiding this comment.
s/with/will probably
| } | ||
|
|
||
| message StatusRequest{ | ||
| // A action request is streamed from the Elastic Agent to the application so an action can be performed |
There was a problem hiding this comment.
very minor s/A action/An action
elastic-agent-client.proto
Outdated
| message ActionRequest { | ||
| // Token that is used to unique identify the application to agent. When agent started this | ||
| // application it would have provided it this token. | ||
| string token = 1; |
There was a problem hiding this comment.
do we need unique token when sending req from agent to application? it should be probably moved to ActionResponse
There was a problem hiding this comment.
You are correct it would be more appropriate on ActionResponse but being that Agent shouldn't even send a ActionRequest until the application has checked in with the correct unique token, then really this can be removed all together (I removed it).
Updates the client protocol to reverse the connection adding the Checkin and Actions bi-directional streams.