Conversation
blakerouse
left a comment
There was a problem hiding this comment.
Looks good, seems like a great starting point.
|
When we start creating the new contracts, let's add a changelog so we can communicate ou changes with endpoint. |
There was a problem hiding this comment.
I've taken another look at this, we want this code to follow the elastic license and not APL2.0 license.
So I believe just for consistency is to have the same structure as every other Elasticsearch project and move the code into an x-pack folder and include the license file. This also remove the need for us to have a special license file that deviates from other projects.
With that change, we will have the header, the directory and the generic license file which should make it obvious what license it's been developed on.
Another thing, let's make sure the proto file also has the header.
WDYT @ruflin, @blakerouse @mostlyjason
|
As I expect all of this code to be under ES license I don't think we need the x-pack prefix, it would only complicate the code structure. And yes, we need the headers. |
|
updated with proto file license header generation |
|
lets get that merged @michalpristas to iterate. |
Matches the one from beats repo
running mage update will generate client code and injects a license header
cc @ph @blakerouse