Update github.com/docker/docker dependency to v28.1.1#116
Merged
ycombinator merged 4 commits intoelastic:mainfrom May 7, 2025
Merged
Update github.com/docker/docker dependency to v28.1.1#116ycombinator merged 4 commits intoelastic:mainfrom
ycombinator merged 4 commits intoelastic:mainfrom
Conversation
3 tasks
pkoutsovasilis
left a comment
There was a problem hiding this comment.
install_go_dependencies() {
local install_packages=(
"github.com/magefile/mage"
"github.com/elastic/go-licenser"
"golang.org/x/tools/cmd/goimports"
"github.com/jstemmer/go-junit-report"
"gotest.tools/gotestsum"
)
for pkg in "${install_packages[@]}"; do
go install "${pkg}@latest"
done
}
this part of the code is causing us issues 🤔
Contributor
Author
Yeah, specifically, the issue is with updating I guess we will need to bump the repo's Go version to |
leehinman
approved these changes
May 7, 2025
Contributor
💚 Build Succeeded
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the github.com/docker/docker module dependency to v28.1.1 and does a bit of related cleanup:
types.EventsOptionswithevents.ListOptionsas the former has been removed from the Docker API in the new version.types.Container->container.Summarytypes.ContainerJSON->container.InspectResponsetypes.SummaryNetworkSettings->container.NetworkSettingsSummaryAlso updates Go version to
1.24.1as CI was failing without that (see #116 (comment)).