Merged
Conversation
jlind23
approved these changes
Jul 22, 2024
Contributor
|
@pazone the build is failing as the Windows VM are using 1.20 whereas they should now be using Go 1.21, could you please help us out here? |
Contributor
|
@michalpristas Looks like this PR would close out #91? |
|
Looks like the Go version is specified here: https://github.com/elastic/elastic-agent-autodiscover/blob/main/.buildkite/pipeline.yml#L5 Updating that is probably the quickest fix, though I think that we try to preinstall Go on most of the images as well (possibly a future improvement to look at). |
Contributor
|
Thanks @rowlandgeoff, I'll try to bump it here - #101 |
98e340e to
de9152a
Compare
Contributor
💚 Build Succeeded
History
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated dependency is needed for agent.
Replaced deprecated type
type.ContainerListOptionswithcontainer.ListOptions