Skip to content

[8.4](backport #864) Add control-plane toleration to Agent K8S manifests.#907

Merged
ph merged 1 commit into8.4from
mergify/bp/8.4/pr-864
Aug 17, 2022
Merged

[8.4](backport #864) Add control-plane toleration to Agent K8S manifests.#907
ph merged 1 commit into8.4from
mergify/bp/8.4/pr-864

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Aug 11, 2022

This is an automatic backport of pull request #864 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@yashtewari @mergify
Add control-plane toleration to Agent K8S manifests. (#864)
dffcbe1 
* Add toleration to elastic-agent Kubernetes manifests.

The toleration with key node-role.kubernetes.io/control-plane is set to replace
the deprecated toleration with key node-role.kubernetes.io/master which will be
removed by Kubernetes v1.25

* Remove outdated "master" node terminology.

(cherry picked from commit 689aee3)
@mergify mergify bot requested a review from a team as a code owner August 11, 2022 18:31
@mergify mergify bot added the backport label Aug 11, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 11, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-11T18:31:27.181+0000

  • Duration: 20 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 6134
Skipped 23
Total 6157

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 11, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 97.26% (71/73) 👍
Files 67.857% (152/224) 👍
Classes 68.161% (304/446) 👍
Methods 51.831% (835/1611) 👍
Lines 38.283% (9096/23760) 👎 -0.025
Conditionals 100.0% (0/0) 💚

gizas
gizas approved these changes Aug 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@gizas gizas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above changes need to manually imported also here:

https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/server/services/elastic_agent_manifest.ts#L28

https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/server/services/elastic_agent_manifest.ts#L303

@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Aug 15, 2022

This pull request has not been merged yet. Could you please review and merge it @yashtewari? 🙏

@ph
Copy link
Copy Markdown
Contributor

ph commented Aug 16, 2022

@gizas I didn't expect changes would be required in kibana, should the change only target the next release 8.5.0 and not 8.4.0 and 8.3.0?

@gizas
Copy link
Copy Markdown
Contributor

gizas commented Aug 17, 2022

I would say to exist also in 8.3 and 8.4 in order to be aligned.

FYI I see them in the automatic PR https://github.com/elastic/kibana/pull/138713/files that was created from here . Still not merged

@ph ph merged commit 42d8ba2 into 8.4 Aug 17, 2022
@mergify mergify bot deleted the mergify/bp/8.4/pr-864 branch August 17, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gizas gizas gizas approved these changes

Assignees

@yashtewari yashtewari

Labels

backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elasticmachine @ph @gizas @yashtewari