[8.4](backport #848) Reload downloader client on config change#868
Merged
michalpristas merged 3 commits intoelastic:8.4from Aug 9, 2022
Merged
[8.4](backport #848) Reload downloader client on config change#868michalpristas merged 3 commits intoelastic:8.4from
michalpristas merged 3 commits intoelastic:8.4from
Conversation
Fix unpacking of artifact config (elastic#776)
Reload downloader client on config change (elastic#848)
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Contributor
🌐 Coverage report
|
narph
approved these changes
Aug 9, 2022
This was referenced Jun 27, 2025
Merged
Merged
[8.19] (backport #8715) Remove logs indicating unprivileged installation mode is still in beta
#8722
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #848 and #776 as prerequisite
What does this PR do?
Downloaders have own instance of client which is used to download artifacts.
This client is created when constructing a downloader instance and exists for the time being.
When configuration changes for
artifacts.downloadclient should be recreated to reflect new proxy/TLS/timeout settings.On top of that this also fixes an issue when agent after failed download does not remove corrupted files which leads to retry of verification loop which fails on
asc and sha512not found errors making downloads and upgrades unusable in a future.This is source of many SDHs which requires manual intervention and cleaning up download directory by user.
Why is it important?