Skip to content

ci(buildkite): use go-version env variable in the pipeline.yml#6893

Closed
v1v wants to merge 3 commits intoelastic:mainfrom
v1v:feature/updatecli-bump-version-files
Closed

ci(buildkite): use go-version env variable in the pipeline.yml#6893
v1v wants to merge 3 commits intoelastic:mainfrom
v1v:feature/updatecli-bump-version-files

Conversation

@v1v
Copy link
Copy Markdown
Member

@v1v v1v commented Feb 17, 2025

What does this PR do?

Use

elastic-agent/.buildkite/hooks/pre-command

Lines 12 to 14 in 08048a9

if [[ -z "${GO_VERSION-""}" ]]; then
export GO_VERSION=$(cat "${WORKSPACE}/.go-version")
fi
to avoid a hardcoded value

Why is it important?

Otherwise, the updatecli pipeline will need to be adapted:

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@v1v v1v self-assigned this Feb 17, 2025
@v1v v1v requested a review from a team as a code owner February 17, 2025 10:26
This was referenced Feb 17, 2025
Closed
Merged
kruskall
kruskall previously approved these changes Feb 17, 2025
View reviewed changes
jlind23
jlind23 previously approved these changes Feb 18, 2025
View reviewed changes
@v1v v1v enabled auto-merge (squash) February 18, 2025 08:55
dliappis
dliappis reviewed Feb 19, 2025
View reviewed changes
.buildkite/pipeline.yml
agents:
image: "golang:1.22.6"
# NOTE: use the go-version env variable that's set in the pre-command hook
image: "golang:${GO_VERSION}"
Copy link
Copy Markdown
Contributor

@dliappis dliappis Feb 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think variables in the precommand hook get evaluated here (only after an agent has started running in the context of a shell)?

Copy link
Copy Markdown
Member Author

@v1v v1v Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's indeed an excellent point!

I guess I'll need to use updatecli for this file then

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 19, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/updatecli-bump-version-files upstream/feature/updatecli-bump-version-files
git merge upstream/main
git push upstream feature/updatecli-bump-version-files

@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Feb 19, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@v1v v1v dismissed stale reviews from jlind23 and kruskall via 8907d66 March 5, 2025 17:03
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 13, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/updatecli-bump-version-files upstream/feature/updatecli-bump-version-files
git merge upstream/main
git push upstream feature/updatecli-bump-version-files

@v1v v1v marked this pull request as draft March 13, 2025 11:22
auto-merge was automatically disabled March 13, 2025 11:22

Pull request was converted to draft

@v1v v1v closed this Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlind23 jlind23 jlind23 left review comments

+2 more reviewers

@dliappis dliappis dliappis left review comments

@kruskall kruskall kruskall left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@v1v v1v

Labels

backport-skip skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@v1v @dliappis @jlind23 @kruskall