Skip to content

[8.x](backport #6068) re-enable otel subcommand on Windows#6156

Merged
pierrehilbert merged 2 commits into8.xfrom
mergify/bp/8.x/pr-6068
Dec 2, 2024
Merged

[8.x](backport #6068) re-enable otel subcommand on Windows#6156
pierrehilbert merged 2 commits into8.xfrom
mergify/bp/8.x/pr-6068

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 27, 2024

What does this PR do?

  1. Re-enables otel subcommand on Windows
  2. Moves launching go routine that processes Windows Service events earlier in boot process
  3. Adds Windows machines to otel integration tests

Why is it important?

Previously when Windows was added, elastic-agent did not respond to the Windows Service manager quickly enough that it was starting and was deemed "unresponsive". Moving the go routine that responds to the Windows Service Manager earlier in the boot process should make this less likely. Given go's design of DLL loading and init code we can't eliminate this completely.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

None.

How to test this PR locally

mage integration:auth
mage integration:test

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...
This is an automatic backport of pull request #6068 done by [Mergify](https://mergify.com).

@leehinman @mergify
re-enable otel subcommand on Windows (#6068)
71a886f 
* move processing windows events earlier in the boot process

* add Windows to otel integration tests

(cherry picked from commit 8e83ce0)
@mergify mergify bot added the backport label Nov 27, 2024
@mergify mergify bot requested a review from a team as a code owner November 27, 2024 15:28
@mergify mergify bot requested review from kaanyalti and pchila and removed request for a team November 27, 2024 15:28
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Nov 27, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 27, 2024

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert pierrehilbert requested review from leehinman and removed request for kaanyalti and pchila November 27, 2024 16:09
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Nov 28, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@mergify
Copy link
Contributor Author

mergify bot commented Dec 2, 2024

This pull request has not been merged yet. Could you please review and merge it @leehinman? 🙏

@pierrehilbert pierrehilbert merged commit 48e7e3a into 8.x Dec 2, 2024
@pierrehilbert pierrehilbert deleted the mergify/bp/8.x/pr-6068 branch December 2, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@leehinman leehinman Awaiting requested review from leehinman

Assignees

@leehinman leehinman

Labels

backport Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elasticmachine @pierrehilbert @leehinman