refactor: remove calls to deprecated rand.Seed function#5334
Merged
andrzej-stencel merged 4 commits intoelastic:mainfrom Aug 26, 2024
Merged
refactor: remove calls to deprecated rand.Seed function#5334andrzej-stencel merged 4 commits intoelastic:mainfrom
andrzej-stencel merged 4 commits intoelastic:mainfrom
Conversation
The function has been deprecated since Go 1.20: https://pkg.go.dev/math/rand#Seed.
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Contributor
|
This pull request does not have a backport label. Could you fix it @andrzej-stencel? 🙏
NOTE: |
mauri870
approved these changes
Aug 21, 2024
pchila
approved these changes
Aug 22, 2024
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes calls to the deprecated rand.Seed function.
Why is it important?
It removes code that serves no purpose. Less code is better.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E test