Skip to content

Add Elastic Infra Metrics processor to otel mode#4968

Merged
michalpristas merged 6 commits intoelastic:mainfrom
andrzej-stencel:otel-add-elastic-infra-metrics-processor
Jun 21, 2024
Merged

Add Elastic Infra Metrics processor to otel mode#4968
michalpristas merged 6 commits intoelastic:mainfrom
andrzej-stencel:otel-add-elastic-infra-metrics-processor

Conversation

@andrzej-stencel
Copy link
Contributor

@andrzej-stencel andrzej-stencel commented Jun 20, 2024 •
edited
Loading

What does this PR do?

This PR makes the Elastic Infra Metrics processor available to users running Elastic Agent in otel mode.

Why is it important?

The processor translates OTel native metrics to those understood by the Elastic system integration.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

No impact expected.

How to test this PR locally

  1. Build the agent locally (see docs)
  2. Unpack the .tar.gz archive in build/distributions
  3. Run the built binary with `build/distributions/elastic-agent-*/elastic-agent otel --config internal/pkg/otel/testdata/all-components.yml

Related issues

@andrzej-stencel andrzej-stencel added the enhancement New feature or request label Jun 20, 2024
@andrzej-stencel andrzej-stencel requested a review from a team as a code owner June 20, 2024 06:42
@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2024

This pull request does not have a backport label. Could you fix it @andrzej-stencel? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@AlexanderWert AlexanderWert linked an issue Jun 20, 2024 that may be closed by this pull request
Make elasticinframetricsprocessor available in otel mode #4969
Closed
1 task
@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b otel-add-elastic-infra-metrics-processor upstream/otel-add-elastic-infra-metrics-processor
git merge upstream/main
git push upstream otel-add-elastic-infra-metrics-processor

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jun 20, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 20, 2024

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

rogercoll
rogercoll reviewed Jun 21, 2024
View reviewed changes
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Jun 21, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@michalpristas michalpristas merged commit 1ca6594 into elastic:main Jun 21, 2024
@michalpristas michalpristas mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rogercoll rogercoll rogercoll left review comments

@michalpristas michalpristas michalpristas approved these changes

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-control-plane

+1 more reviewer

@ishleenk17 ishleenk17 ishleenk17 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@andrzej-stencel andrzej-stencel

Labels

backport-skip enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make elasticinframetricsprocessor available in otel mode

7 participants

@andrzej-stencel @elasticmachine @michalpristas @rogercoll @ishleenk17 @pierrehilbert @ChrsMark