[9.3] (backport #11740) Avoid uninstalling and re-installing service components on policy change#12100
Merged
ycombinator merged 1 commit into9.3from Jan 6, 2026
Merged
Conversation
…nge (#11740) * Add UsesCommandRuntime and UsesServiceRuntime methods on Component * Use new methods * Add test case for only output being changed on service component * Implement logic to not remove and add same service component * Adding CHANGELOG fragment * Improve comment * Fix logic location * Update unit test * Update service component naming * Refactor: extract logic into helper method * Relocate unit test and add lots of cases * Remove unnecessary code * Clarify comments * Remove unnecessary unit test * Undo unnecessary changes * Update component ID in integration test * Add assertions on lengths of components added, removed, updated * Add test case for only input ID changing * Add integration test: TestPolicyReassignWithTamperProtectedEndpoint * Update replace in go.mod * Bump up context timeout and use for entire test * Define fixture * Fix syntax errors * Fix installOpts * Only cleanup Endpoint using first policy's uninstall token until successful policy reassignment * Clarify log message * Upgrade endpoint package version * Use exec.CommandContext and separate out args * Compare Endpoint policy IDs * Use agentID from enrollment response * Install Elastic Defend in second policy * Add endpoint cleanup after reassigning policy * Fixing log messages * Give Endpoint time to receive reassigned policy * Updating dependency version * Adding log statements * Remove replace * Remove duplicate CHANGELOG fragment * Remove PID checks (cherry picked from commit c8deb6d)
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
ycombinator
approved these changes
Jan 6, 2026
Contributor
💚 Build Succeeded
cc @ycombinator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR identifies Service Runtime components with only their input type; the output ID is not longer used.
Why is it important?
Service Runtime components are intended to be kept running (via a service) for as long as possible. We should only install/start or uninstall/stop them if they are being explicitly added or removed, respectively, from the component model. If only their configuration is being updated, we should keep the component running.
If a component's ID changes between the last and current component models, Elastic Agent will ask the component's service to uninstall and then reinstall itself. Prior to this PR, service components' ID were determined by their input type and output ID. Therefore, if a service component's output were changed, it would cause the service to be uninstall and then reinstalled. This is undesirable behavior, as services should be kept running as long as possible.
With the changes in this PR, we no longer consider the output ID when generating service components' IDs. If a service component's output is changed, it's ID remains the same between the last and current component models. Elastic Agent does not uninstall and reinstall the component's service but simply passes the configuration change to it (which it was doing prior to this PR anyway).
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog toolI have added an integration test or an E2E testDisruptive User Impact
None.
How to test this PR locally
Policy reassign does not uninstall/reinstall Endpoint
default: containing only thesystemintegrationtp-es: containing the Elastic Defend integration, with tamper protection enabled, and using the Elasticsearch output.tp-ls: containing the Elastic Defend integration, with tamper protection enabled, and using the Logstash output. Note that you will need to create the Logstash output in Fleet > Settings.tp-espolicy and verify the agent is healthy and shipping data.tp-lspolicy.uninstall endpoint service./opt/Elastic/Endpoint/state/log/on Linux) and make sure that Endpoint has connected to Logstash (or has attempted to and failed if there is no actual Logstash endpoint listening).Removing Endpoint from policy uninstalls Endpoint
defaultpolicy.stopping endpoint service runtime, followed byuninstall endpoint service, followed byStopped: endpoint service runtime.Related issues
Questions to ask yourself
This is an automatic backport of pull request #11740 done by [Mergify](https://mergify.com).