Skip to content

[8.19] (backport #9392) Enhancement/5235 use disk space error to set upgrade detail in coordinator#10055

Merged
kaanyalti merged 2 commits into8.19from
mergify/bp/8.19/pr-9392
Sep 24, 2025
Merged

[8.19] (backport #9392) Enhancement/5235 use disk space error to set upgrade detail in coordinator#10055
kaanyalti merged 2 commits into8.19from
mergify/bp/8.19/pr-9392

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Sep 19, 2025

PR 6/6

  • Enhancement

What does this PR do?

Why is it important?

  • Disk space errors are not user friendly, so when the upgrade state shows the os disk space error the status output and the fleet ui gets cluttered.
  • By setting the detail error to ErrInsufficientDiskSpaceError we are now providing a consistent and concise error message to the user.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Disruptive User Impact

none

How to test this PR locally

  • Coordinator unit test is sufficient

Related issues

This is an automatic backport of pull request #9392 done by [Mergify](https://mergify.com).

@mergify
Enhancement/5235 use disk space error to set upgrade detail in coordi…
9fe8d05 
…nator (#9392)

* enhancement(5235): added insufficinet disk space error handling in the coordinator

* enhancement(5235): added coordinator tests for insufficient disk space error

enhancement(5235): updated error in test

enhancement(5235): fix coordinator test

* enhancement(5235): added changelog fragment

(cherry picked from commit a7a76f6)

# Conflicts:
#	internal/pkg/agent/application/coordinator/coordinator_unit_test.go
@mergify mergify bot requested a review from a team as a code owner September 19, 2025 11:38
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Sep 19, 2025
@mergify mergify bot requested review from pchila and ycombinator and removed request for a team September 19, 2025 11:38
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Sep 19, 2025

Cherry-pick of a7a76f6 has failed:

On branch mergify/bp/8.19/pr-9392
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit a7a76f6e1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   changelog/fragments/1757010848-agent-responds-with-clean-insufficient-disk-space-error-message.yaml
	modified:   internal/pkg/agent/application/coordinator/coordinator.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   internal/pkg/agent/application/coordinator/coordinator_unit_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Sep 19, 2025
Merged
4 tasks
@github-actions github-actions bot added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Sep 19, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 19, 2025

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Sep 22, 2025

This pull request has not been merged yet. Could you please review and merge it @kaanyalti? 🙏

@ebeahan
Copy link
Copy Markdown
Member

ebeahan commented Sep 23, 2025

@kaanyalti can you take a look at this backport?

@kaanyalti kaanyalti removed the conflicts There is a conflict in the backported pull request label Sep 24, 2025
@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Sep 24, 2025

Quality Gate passed Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 24, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @kaanyalti

@kaanyalti kaanyalti merged commit 219ea59 into 8.19 Sep 24, 2025
20 checks passed
@kaanyalti kaanyalti deleted the mergify/bp/8.19/pr-9392 branch September 24, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ycombinator ycombinator Awaiting requested review from ycombinator ycombinator is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

1 more reviewer

@kaanyalti kaanyalti kaanyalti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kaanyalti kaanyalti

Labels

backport Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elasticmachine @ebeahan @kaanyalti