Skip to content

update branch to main#111

Merged
v1v merged 1 commit intoelastic:mainfrom
v1v:feature/update-main
Dec 17, 2021
Merged

update branch to main#111
v1v merged 1 commit intoelastic:mainfrom
v1v:feature/update-main

Conversation

@v1v
Copy link
Copy Markdown
Member

@v1v v1v commented Dec 16, 2021

No description provided.

@v1v v1v requested review from a team, bmorelli25 and trentm December 16, 2021 17:35
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Dec 16, 2021
@ghost
Copy link
Copy Markdown

ghost commented Dec 16, 2021 •
edited by ghost
Loading

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-16T18:56:45.308+0000

  • Duration: 8 min 28 sec

  • Commit: 904387f

Steps errors 2

Expand to view the steps failures

Run tests
  • Took 0 min 2 sec . View more details here
  • Description: .ci/run-test.sh
Run tests
  • Took 0 min 2 sec . View more details here
  • Description: .ci/run-test.sh

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v v1v mentioned this pull request Dec 16, 2021
Merged
bmorelli25
bmorelli25 approved these changes Dec 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs! A lot of these links should be moved to attributes so we don't have to maintain them manually like this. I've opened https://github.com/elastic/observability-docs/issues/1393 to address this.

@trentm
Copy link
Copy Markdown
Member

trentm commented Dec 16, 2021

The changes look good.

However, I don't understand these test failures. For some reason, when running the Node v16 and v17 steps in Jenkins CI, inside the "node:16" and "node:17" docker containers, the current node version is 8.17.0?!

https://apm-ci.elastic.co/blue/organizations/jenkins/apm-agent-nodejs%2Fecs-logging-nodejs-mbp/detail/PR-111/1/pipeline/103

[2021-12-16T17:42:24.946Z] + .ci/run-install.sh
...
[2021-12-16T17:42:24.946Z] + npm --prefix /var/lib/jenkins/workspace/js_ecs-logging-nodejs-mbp_PR-111/src/go.elastic.co/apm/ecs-logging-nodejs/helpers install
...
[2021-12-16T17:42:47.983Z] npm WARN notsup Unsupported engine for fast-json-stringify@2.7.12: wanted: {"node":">= 10.0.0"} (current: {"node":"8.17.0","npm":"6.13.4"})
...

@v1v
Copy link
Copy Markdown
Member Author

v1v commented Dec 16, 2021

If I run the below command locally I cannot reproduce the error:

docker run --rm -ti -v $(pwd):/app node:16 /bin/bash
$ cd /app
$ .ci/run-install.sh
$ .ci/run-test.sh

Maybe some cached docker images are wrongly pointing to node:8 rather than node:16?

@v1v
Copy link
Copy Markdown
Member Author

v1v commented Dec 17, 2021

Unrelated test errors, I'll raise an issue to track those errors

@v1v v1v merged commit 26aaa6a into elastic:main Dec 17, 2021
@v1v v1v mentioned this pull request Dec 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trentm trentm trentm approved these changes

@cachedout cachedout cachedout approved these changes

@bmorelli25 bmorelli25 bmorelli25 approved these changes

Assignees

No one assigned

Labels

agent-nodejs Make available for APM Agents project planning.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@v1v @trentm @cachedout @bmorelli25 @elastic-apm-tech