Skip to content

update branch to main#172

Merged
v1v merged 4 commits intoelastic:mainfrom
v1v:feature/update-main
Dec 17, 2021
Merged

update branch to main#172
v1v merged 4 commits intoelastic:mainfrom
v1v:feature/update-main

Conversation

@v1v
Copy link
Copy Markdown
Member

@v1v v1v commented Dec 16, 2021

No description provided.

@v1v v1v requested review from a team, Mpdreamz and bmorelli25 December 16, 2021 17:50
@v1v v1v self-assigned this Dec 16, 2021
@v1v v1v mentioned this pull request Dec 16, 2021
Merged
@ghost
Copy link
Copy Markdown

ghost commented Dec 16, 2021 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-17T09:16:14.622+0000

  • Duration: 27 min 33 sec

  • Commit: a407916

Test stats 🧪

Test Results
Failed 0
Passed 80
Skipped 0
Total 80

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

cachedout
cachedout reviewed Dec 16, 2021
View reviewed changes
bmorelli25
bmorelli25 approved these changes Dec 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for updating the docs!

v1v
v1v commented Dec 16, 2021
View reviewed changes
Mpdreamz
Mpdreamz approved these changes Dec 17, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ecs-dotnet/build/scripts/Targets.fs

Line 134 in 3152181

| None -> "master"

Needs to be updated to but is unrelated to this repo moving to main. It's an effect of ecs-logging moving.

@v1v
Copy link
Copy Markdown
Member Author

v1v commented Dec 17, 2021

ecs-dotnet/build/scripts/Targets.fs

Thanks for the heads up, I'll commit those changes here

@v1v v1v requested a review from Mpdreamz December 17, 2021 09:15
Mpdreamz
Mpdreamz approved these changes Dec 17, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @v1v !

@v1v v1v merged commit 909c465 into elastic:main Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cachedout cachedout cachedout approved these changes

@Mpdreamz Mpdreamz Mpdreamz approved these changes

@bmorelli25 bmorelli25 bmorelli25 approved these changes

Assignees

@v1v v1v

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@v1v @cachedout @Mpdreamz @bmorelli25